Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pages: Add quick actions to change the homepage and the posts page #40699

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Pages: Add quick actions to change the homepage and the posts page #40699

wants to merge 4 commits into from

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Dec 20, 2024 •
edited
Loading

Part of Automattic/wp-calypso#95620

Proposed changes:

In order to remove the Pages screen from Calypso, we need to port some missing features to WP Admin first.

One of these features is the ability to change the homepage and the posts page directly from the pages list:

Screenshot 2024-12-19 at 11 01 11

This PR implements it in WP Admin as quick actions displayed in the pages list:

Screenshot 2024-12-19 at 13 47 52

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply these changes to your WP.com site
  • Go to /wp-admin/options-reading.php and note the current settings for the homepage/posts page.
  • Go to /wp-admin/edit.php?post_type=page
  • Make sure the quick actions are available (✅) or not (❌) according to the following conditions. Basically, if you don't see them in Calypso, you shouldn't get them in WP Admin; if you don't see them in Calypso, you shouldn't get them in WP Admin.
Scenario Set as homepage Set as posts page Unset as posts page
Homepage: Latest posts ❌ ❌ ❌
Homepage: Static page – None selected
Posts page: None selected		 ❌ ❌ ❌
Homepage: Static page – None selected
Posts page: Something selected		 ❌ ❌ ❌
Homepage: Static page – Something selected
Posts page: None selected		 ✅ (*)
(*) Except on the current homepage		 ✅ ❌
Homepage: Static page – Something selected
Posts page: Something selected		 ✅ (*)
(*) Except on the current homepage		 ✅ (*)
(*) Except on the current post page		 ✅ (*)
(*) Only on the current post page
  • Make sure you can use the quick actions to change the homepage/posts page settings.

@mmtr mmtr self-assigned this Dec 20, 2024
@mmtr mmtr added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress labels Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/remove-duplicate-views-pages-quick-actions branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/remove-duplicate-views-pages-quick-actions

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@mmtr mmtr force-pushed the update/remove-duplicate-views-pages-quick-actions branch from 0f63142 to 3927b27 Compare December 20, 2024 10:45
@mmtr mmtr requested a review from a team December 20, 2024 11:36
@mmtr mmtr mentioned this pull request Dec 20, 2024
Closed
3 tasks
@BogdanUngureanu
Copy link
Contributor

Screen.Recording.2024-12-20.at.17.14.50.mov

Set as posts page doesn't seem to work :(

@mmtr
Copy link
Member Author

mmtr commented Dec 20, 2024

@BogdanUngureanu Good catch! Fixed in 47fbb06

@mmtr mmtr mentioned this pull request Dec 20, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mmtr mmtr

Labels
[mu wpcom Feature] Pages [Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Team Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmtr @BogdanUngureanu